-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: for remote_json authorizer, add headers #1140
feat: for remote_json authorizer, add headers #1140
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1140 +/- ##
==========================================
- Coverage 78.16% 77.58% -0.59%
==========================================
Files 80 79 -1
Lines 3898 3992 +94
==========================================
+ Hits 3047 3097 +50
- Misses 576 616 +40
- Partials 275 279 +4 ☔ View full report in Codecov by Sentry. |
d769d2d
to
031639d
Compare
031639d
to
eff951b
Compare
Code coverage is lowered due to some extra lines being tracked for HEAD: https://app.codecov.io/gh/ory/oathkeeper/pull/1140/tree/internal/cloudstorage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! 🎉 Your contribution makes Ory better :)
✨(authorizers): for remote_json, introduce the ability to specify headers
⬆️ Bump
github.com/ory/x
tov0.0.605
to pass the build fixing vulnerabilitiesRelated issue(s)
#969
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
Corresponding Docs PR ory/docs#1604